Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add global-state-syncer for handling data to etcd. #43113

Merged
merged 5 commits into from
Apr 19, 2023
Merged

ddl: add global-state-syncer for handling data to etcd. #43113

merged 5 commits into from
Apr 19, 2023

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #43112

Problem Summary:

What is changed and how it works?

Add some interfaces for stateSyncer as following:

type StateSyncer interface {
	Init(ctx context.Context) error
	UpdateGlobalState(ctx context.Context, stateInfo *StateInfo) error
	GetGlobalState(ctx context.Context) (*StateInfo, error)
	IsUpgradingState() bool
	WatchChan() clientv3.WatchChan
	Rewatch(ctx context.Context)
}

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 18, 2023
@zimulala zimulala force-pushed the zimuxia/state-syncer branch from 1d98603 to f194392 Compare April 18, 2023 03:09
@pingcap pingcap deleted a comment from ti-chi-bot Apr 18, 2023
@pingcap pingcap deleted a comment from ti-chi-bot Apr 18, 2023
Defined2014
Defined2014 reviewed Apr 18, 2023
View reviewed changes
ddl/syncer/state_syncer_test.go
func TestStateSyncerSimple(t *testing.T) {
variable.EnableMDL.Store(false)
if runtime.GOOS == "windows" {
t.Skip("integration.NewClusterV3 will create file contains a colon which is not allowed on Windows")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we now support compiling TiDB on windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I think that's supportive. I checked, and the SecureBootstrap is not supported.

Copy link
Contributor

@Defined2014 Defined2014 Apr 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean maybe we could just let it compile failed. But it's not a serious issue. Just keep it now. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it in the other tests, so I added it here.

ddl/syncer/state_syncer.go Outdated Show resolved Hide resolved
@zimulala zimulala force-pushed the zimuxia/state-syncer branch from 74c4c5c to 20ef032 Compare April 18, 2023 06:13
@pingcap pingcap deleted a comment from ti-chi-bot Apr 18, 2023
@zimulala
Copy link
Contributor Author

PTAL @Defined2014

@pingcap pingcap deleted a comment from ti-chi-bot Apr 18, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
@zimulala
Copy link
Contributor Author

PTAL @tangenta

@zimulala
Copy link
Contributor Author

Found a failed UT: #43170

@pingcap pingcap deleted a comment from ti-chi-bot Apr 19, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2023
@hawkingrei
Copy link
Member

/retest

@zimulala
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 33d5762

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2023
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot merged commit 38f3be4 into pingcap:master Apr 19, 2023
@zimulala zimulala deleted the zimuxia/state-syncer branch May 26, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add global state syncer for handling data to etcd.
4 participants
@zimulala @ti-chi-bot @hawkingrei @Defined2014