Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: retry on unknown RPC error, log more info to help debug (#43293) #43340

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43293

What problem does this PR solve?

Issue Number: close #43291

Problem Summary:

What is changed and how it works?

  • log region/peer/store info on write tikv error
  • log error when failed to import table
  • retry on unknown rpc error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • return context.Canceled or other non-retryable error, see the log print accordingly.
    • return non-retryable error during write, see if it contains region/peer/store info:
[2023/04/21 18:05:33.809 +08:00] [ERROR] [import.go:1631] ["failed to import table"] [table=`xxx`.`xxx`] [error="peer 173, store 1, region 172, epoch conf_ver:1 version:82 : rpc error: code = Unimplemented desc = fake error"] [errorVerbose="rpc error: code = Unimplemented desc = fake error\npeer 173, store 1, region 172, epoch conf_ver:1 version:82 \ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.(*Backend).writeToTiKV.func2\n\t/Users/jujiajia/code/pingcap/tidb/br/pkg/lightning/backend/local/region_job.go:220\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.(*Backend).writeToTiKV.func3\n\t/Users/jujiajia/code/pingcap/tidb/br/pkg/lightning/backend/local/region_job.go:282\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.(*Backend).writeToTiKV\n\t/Users/jujiajia/code/pingcap/tidb/br/pkg/lightning/backend/local/region_job.go:312\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.(*Backend).executeJob\n\t/Users/jujiajia/code/pingcap/tidb/br/pkg/lightning/backend/local/local.go:1347\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.(*Backend).startWorker\n\t/Users/jujiajia/code/pingcap/tidb/br/pkg/lightning/backend/local/local.go:1261\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.(*Backend).doImport.func3\n\t/Users/jujiajia/code/pingcap/tidb/br/pkg/lightning/backend/local/local.go:1529\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\t/Users/jujiajia/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_arm64.s:1172"]
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 24, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Apr 24, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 24, 2023
Copy link
Contributor

@niubell niubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 24, 2023
@D3Hunter
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 50455f8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2023
@D3Hunter
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit db9c538 into pingcap:release-7.1 Apr 24, 2023
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants