Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix data race in the buildMemTableReader #43431

Merged
merged 4 commits into from
May 4, 2023
Merged

executor: fix data race in the buildMemTableReader #43431

merged 4 commits into from
May 4, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Apr 26, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43118

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 26, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the try_to_fix_data_race branch from 96033a5 to 4373037 Compare May 4, 2023 06:43
hawkingrei added 2 commits May 4, 2023 15:15
@hawkingrei
update
7579e06 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
7416c47 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested a review from Defined2014 May 4, 2023 08:01
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 4, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 4, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 7416c47

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit 79729c3 into pingcap:master May 4, 2023
@hawkingrei hawkingrei deleted the try_to_fix_data_race branch May 4, 2023 08:06
@hawkingrei
Copy link
Member Author

/cherrypick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request May 4, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #43525.

In response to this:

/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 4, 2023
@ti-chi-bot
executor: fix data race in the buildMemTableReader (#43431) (#43525)
32b5ddd 
close #43118
Defined2014 pushed a commit to Defined2014/tidb that referenced this pull request Aug 27, 2024
@hawkingrei @Defined2014
executor: fix data race in the buildMemTableReader (pingcap#43431)
d10f652 
close pingcap#43118
@Defined2014
Copy link
Contributor

/cherrypick release-6.5

@ti-chi-bot
Copy link
Member

@Defined2014: new pull request created to branch release-6.5: #55674.

In response to this:

/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 27, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#43431
391290f 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 27, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@ti-chi-bot
executor: fix data race in the buildMemTableReader (#43431) (#55674)
6ea9184 
close #43118
Defined2014 pushed a commit to Defined2014/tidb that referenced this pull request Aug 29, 2024
@hawkingrei @Defined2014
executor: fix data race in the buildMemTableReader (pingcap#43431)
742284c 
close pingcap#43118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the executor.buildMemTableReader
4 participants
@hawkingrei @ti-chi-bot @Defined2014 @tiancaiamao