Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: flush data in local engine serially #43524

Merged
merged 10 commits into from
May 6, 2023
Merged

ddl: flush data in local engine serially #43524

merged 10 commits into from
May 6, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented May 4, 2023

What problem does this PR solve?

Issue Number: close #43523

Problem Summary:

We should not call FlushEngine() concurrently.

What is changed and how it works?

Aquire the lock before FlushEngine().

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 4, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2023
zimulala
zimulala approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 5, 2023
Benjamin2037
Benjamin2037 reviewed May 5, 2023
View reviewed changes
ddl/index.go Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 reviewed May 5, 2023
View reviewed changes
ddl/ingest/backend.go Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 approved these changes May 6, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta
Copy link
Contributor Author

tangenta commented May 6, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 425f9f4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2023
@tangenta
Copy link
Contributor Author

tangenta commented May 6, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit a246538 into pingcap:master May 6, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 6, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43571.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 6, 2023
@tangenta @ti-chi-bot
This is an automated cherry-pick of pingcap#43524
4d70d3d 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request May 9, 2023
@ti-chi-bot
ddl: flush data in local engine serially (#43524) (#43571)
6041250 
close #43523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected fallback to txn-merge mode while creating index
5 participants
@tangenta @ti-chi-bot @zimulala @Benjamin2037 @wjhuang2016