-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_control: update static calibrate cpu params #43969
Conversation
Signed-off-by: husharp <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: husharp <[email protected]>
@nolouch @glorv @CabinfeverB PTAL, thx! |
@CabinfeverB: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/review default |
Pull Request ReviewTitle
DescriptionThe pull request aims to fix the issue referenced in #43212 by updating the static calibrate CPU parameters. The main change is in the conversion from seconds to milliseconds for the CPU value. ChangesThe changes include:
Potential problems
SuggestionsNo immediate suggestions, as the pull request appears to address the issue described in #43212. Markdown Summary- **Title**: resource_control: update static calibrate cpu params
- **Problem**: Inaccurate CPU time unit conversion in resource control static calibration
- **Changes**:
1. Renamed `tidbCPU` to `tidbToKVCPURatio`
2. Updated CPU calculation formula to convert seconds to milliseconds
3. Fixed some minor typographical issues and updated test cases
- **Potential Problems**: None
- **Suggestions**: Verify if additional test cases are necessary for validation. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d6d71eb
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #44012
Problem Summary:
What is changed and how it works?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.