Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: key ranges should be sorted in batch cop retry (#44623) #44632

Merged
merged 6 commits into from
Jun 16, 2023
Merged

store: key ranges should be sorted in batch cop retry (#44623) #44632

merged 6 commits into from
Jun 16, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44623

What problem does this PR solve?

Issue Number: close #44622

Problem Summary:

What is changed and how it works?

sort keyRanges when retry batch cop

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 13, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 13, 2023
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2023
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 13, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 15, 2023
windtalker
windtalker approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 15, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 15, 2023
@windtalker
Copy link
Contributor

/rebuild

@windtalker
Copy link
Contributor

/retest

@windtalker
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 15, 2023
windtalker
windtalker approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-15 08:18:59.996993042 +0000 UTC m=+246536.411597114: ☑️ agreed by XuHuaiyu.
  • 2023-06-15 08:20:23.97735603 +0000 UTC m=+246620.391960107: ☑️ agreed by windtalker.
  • 2023-06-15 08:25:36.334927737 +0000 UTC m=+246932.749531815: ✖️🔁 reset by windtalker.
  • 2023-06-15 09:45:18.492767976 +0000 UTC m=+251714.907372054: ☑️ agreed by XuHuaiyu.
  • 2023-06-15 09:46:23.670239897 +0000 UTC m=+251780.084843976: ☑️ agreed by windtalker.

@windtalker
Copy link
Contributor

/run-unit-test

2 similar comments
@windtalker
Copy link
Contributor

/run-unit-test

@windtalker
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 9d4f30d into pingcap:release-5.3 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@windtalker windtalker

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @windtalker @XuHuaiyu