Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support remain time for show analyze #44791

Merged
merged 1 commit into from
Jun 19, 2023
Merged

executor: support remain time for show analyze #44791

merged 1 commit into from
Jun 19, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 19, 2023 •
edited
Loading

Reverts #44717

What problem does this PR solve?

Issue Number: ref #44033

Problem Summary:

What is changed and how it works?

re-support remain time for show analyze

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 19, 2023
@hawkingrei hawkingrei changed the title Revert "executor: remove remain time for show analyze" executor: support remain time for show analyze Jun 19, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 19, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, xuyifangreeneyes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qw4990,xuyifangreeneyes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-19 09:20:47.321730581 +0000 UTC m=+8212.722981024: ☑️ agreed by qw4990.
  • 2023-06-19 09:22:48.623414032 +0000 UTC m=+8334.024664480: ☑️ agreed by xuyifangreeneyes.

@ti-chi-bot ti-chi-bot bot merged commit b5dbe69 into master Jun 19, 2023
@ti-chi-bot ti-chi-bot bot deleted the revert-44717-remove_remain_time branch June 19, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkingrei @qw4990 @xuyifangreeneyes