Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: simply refactor the code called "needCheckClusterState" #45660

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #39751

Problem Summary:

What is changed and how it works?

  • Rename needCheckClusterState to checkAndUpdateClusterState
  • Using checkAndUpdateClusterState instead of doCheckClusterState, then remove doCheckClusterState.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2023
@tiprow
Copy link

tiprow bot commented Jul 28, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #45660 (f11d861) into master (5ae5abf) will increase coverage by 0.1454%.
Report is 27 commits behind head on master.
The diff coverage is 37.5000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45660        +/-   ##
================================================
+ Coverage   73.2295%   73.3749%   +0.1454%     
================================================
  Files          1270       1277         +7     
  Lines        389911     392627      +2716     
================================================
+ Hits         285530     288090      +2560     
- Misses        86089      86182        +93     
- Partials      18292      18355        +63     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3667% <37.5000%> (+0.1372%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0417% <ø> (ø)
br 52.8006% <ø> (+0.6830%) ⬆️

@zimulala zimulala requested a review from Defined2014 July 31, 2023 02:48
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 31, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-31 02:51:53.290780824 +0000 UTC m=+67397.233129352: ☑️ agreed by Defined2014.
  • 2023-07-31 03:10:02.347220311 +0000 UTC m=+68486.289568827: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 6a2672c into pingcap:master Jul 31, 2023
@zimulala zimulala deleted the zimuxia/tiny-refactor branch July 31, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants