Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix TestStatsLockAndUnlockTables #45858

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 7, 2023

What problem does this PR solve?

Issue Number: close #45843

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #45858 (b9ff5e2) into master (de30804) will increase coverage by 0.0142%.
Report is 5 commits behind head on master.
The diff coverage is 85.7142%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45858        +/-   ##
================================================
+ Coverage   73.3404%   73.3546%   +0.0142%     
================================================
  Files          1274       1277         +3     
  Lines        393217     393870       +653     
================================================
+ Hits         288387     288922       +535     
- Misses        86445      86532        +87     
- Partials      18385      18416        +31     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3464% <85.7142%> (+0.0060%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0467% <ø> (+0.0108%) ⬆️
br 52.0540% <ø> (+0.0103%) ⬆️

@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

@ywqzzy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 7, 2023
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, YangKeao, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-07 09:02:56.017892752 +0000 UTC m=+3853.651738149: ☑️ agreed by xhebox.
  • 2023-08-07 09:15:47.644629151 +0000 UTC m=+4625.278474544: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit c512ede into pingcap:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable test in stats_lock_test.go
4 participants