-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: optimize load data assignment expressions (#46082) | tidb-test=pr/2145 #46110
executor: optimize load data assignment expressions (#46082) | tidb-test=pr/2145 #46110
Conversation
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test mysql-test tidb-test=pr/2145 |
@gengliqi: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5-20230425-v6.5.2 #46110 +/- ##
================================================================
Coverage ? 73.4033%
================================================================
Files ? 1079
Lines ? 345991
Branches ? 0
================================================================
Hits ? 253969
Misses ? 75593
Partials ? 16429 |
This is an automated cherry-pick of #46082
What problem does this PR solve?
Issue Number: close #46081
Problem Summary:
See #46081.
What is changed and how it works?
Calling
rewriteAstExpr
only once for each expression. Then evaluating these expressions for each row.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.