Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: enable-stats-cache-mem-quota is set to enable by default #46130

Merged
merged 8 commits into from
Aug 30, 2023
Merged

config: enable-stats-cache-mem-quota is set to enable by default #46130

merged 8 commits into from
Aug 30, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 16, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #46158

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #46130 (ba30706) into master (3203c38) will decrease coverage by 0.8272%.
Report is 16 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46130        +/-   ##
================================================
- Coverage   73.4214%   72.5943%   -0.8272%     
================================================
  Files          1299       1324        +25     
  Lines        394104     401534      +7430     
================================================
+ Hits         289357     291491      +2134     
- Misses        86360      91531      +5171     
- Partials      18387      18512       +125
Flag Coverage Δ
integration 25.7332% <63.6363%> (?)
unit 73.3625% <100.0000%> (-0.0590%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0638% <ø> (+0.0005%) ⬆️
br 48.0148% <ø> (-4.3472%) ⬇️

@hawkingrei
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test tiprow_fast_test

@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 16, 2023
@hawkingrei
Copy link
Member Author

/retest

3 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the enable-stats-cache-mem-quota branch 2 times, most recently from f8fe021 to a3fe0a4 Compare August 17, 2023 08:04
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2023
@hawkingrei hawkingrei force-pushed the enable-stats-cache-mem-quota branch 2 times, most recently from e76c420 to f3eb90b Compare August 25, 2023 09:05
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the enable-stats-cache-mem-quota branch from 26c0c29 to f828831 Compare August 29, 2023 03:49
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
update
758b4bd 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the enable-stats-cache-mem-quota branch from f106e23 to 758b4bd Compare August 29, 2023 13:00
@hawkingrei
update
e59971c 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
2910846 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
1f71ed6 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
9e36441 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
7ec40a1 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
ba30706 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 30, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-30 03:20:01.381619813 +0000 UTC m=+1897165.930635785: ☑️ agreed by qw4990.
  • 2023-08-30 03:28:31.755744655 +0000 UTC m=+1897676.304760642: ☑️ agreed by time-and-fate.

@easonn7
Copy link

easonn7 commented Aug 30, 2023

/approve

The primary purpose of this "config" is to serve as a safeguard switch to prevent unexpected behavior after the LFU implementation is released. It ensures that the stats cache reverts to the behavior of the map cache. From a PM perspective, the naming of this config has a gap compared to its actual behavior. Personally, I believe that this setting should not be provided. However, considering the security assurance for new features, I will approve this "config".

In the long term, this "config" should be deprecated, and we should design a variable similar to "fix/feature_control" to manage the toggling behavior of these temporary features. This will avoid adding and deprecating configs/variables for each feature. We will have a separate discussion on this matter.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 99738a3 into pingcap:master Aug 30, 2023
@hawkingrei hawkingrei deleted the enable-stats-cache-mem-quota branch August 31, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 qw4990 approved these changes

@easonn7 easonn7 Awaiting requested review from easonn7

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set enable-stats-cache-mem-quota to default configuration
4 participants
@hawkingrei @easonn7 @qw4990 @time-and-fate