*: use std/slices to replace exp/slices #46250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46250 +/- ##
================================================
- Coverage 73.3737% 72.7673% -0.6065%
================================================
Files 1285 1306 +21
Lines 394836 401353 +6517
================================================
+ Hits 289706 292054 +2348
- Misses 86678 90812 +4134
- Partials 18452 18487 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lance6716
reviewed
Aug 20, 2023
testkit/result.go
Outdated
| } | ||
| } | ||
| return false | ||
| return 1 |
There was a problem hiding this comment.
we need to add more logic like checking the length of slice.
There was a problem hiding this comment.
I have refactored it.
|
/retest |
|
/test all |
Signed-off-by: Weizhen Wang <[email protected]>
Defined2014
approved these changes
Aug 21, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Signed-off-by: Weizhen Wang <[email protected]>
ti-chi-bot
bot
added
size/M
lance6716
approved these changes
Aug 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #45933
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.