statistics: improve code to avoid data race #46309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
hawkingrei
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46309 +/- ##
================================================
- Coverage 73.3517% 73.0321% -0.3196%
================================================
Files 1284 1313 +29
Lines 393256 403343 +10087
================================================
+ Hits 288460 294570 +6110
- Misses 86433 90224 +3791
- Partials 18363 18549 +186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
qw4990
reviewed
Aug 22, 2023
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
ti-chi-bot
bot
added
size/L
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
requested review from
lance6716 and
Rustin170506
and removed request for
lance6716
Signed-off-by: Weizhen Wang <[email protected]>
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
qw4990
reviewed
Aug 23, 2023
|
/test all |
Signed-off-by: Weizhen Wang <[email protected]>
qw4990
approved these changes
Aug 23, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
time-and-fate
approved these changes
Aug 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #46158
Problem Summary:
What is changed and how it works?
I have created a flowchart to facilitate everyone's understanding.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.