disttask: persist subtask error properly

[tangenta]

What problem does this PR solve?

Issue Number: ref #46258

Problem Summary:

Previously, UpdateErrorToSubtask updates all subtasks regardless of global task ID.

What is changed and how it works?

Add taskID parameter to UpdateErrorToSubtask.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #46674 (9e30783) into master (d33cde7) will decrease coverage by 0.6932%.
The diff coverage is 83.3333%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #46674        +/-   ##
================================================
- Coverage   73.3526%   72.6594%   -0.6932%     
================================================
  Files          1318       1339        +21     
  Lines        395829     402059      +6230     
================================================
+ Hits         290351     292134      +1783     
- Misses        86995      91376      +4381     
- Partials      18483      18549        +66     

Flag	Coverage Δ
integration	25.3743% <0.0000%> (?)
unit	73.3465% <100.0000%> (-0.0061%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.0444% <ø> (ø)
parser	84.9581% <ø> (ø)
br	48.1298% <ø> (-4.3316%)	⬇️

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-09-05 08:57:25.376124235 +0000 UTC m=+2435809.925140219: ☑️ agreed by xhebox.
• 2023-09-05 09:13:49.515695397 +0000 UTC m=+2436794.064711384: ☑️ agreed by D3Hunter.

[tangenta]

/retest

[tiprow]

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Benjamin2037]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the test for the pull request and check the finished items in description.

For example:

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}