Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix convert str -00* to uint #46721

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Sep 6, 2023

What problem does this PR solve?

Issue Number: close #44359

Problem Summary:

  • -0 can be converted into unsigned integer in mysql

What is changed and how it works?

  • When converting string to unsized integer, make -0(or -00000*) valid.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2023
@tiprow
Copy link

tiprow bot commented Sep 6, 2023

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@solotzg solotzg changed the title types: fix convert str -0* to uint types: fix convert str -0 to uint Sep 6, 2023
@tiprow
Copy link

tiprow bot commented Sep 6, 2023

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #46721 (0a20cdd) into master (aac330b) will decrease coverage by 0.6203%.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46721        +/-   ##
================================================
- Coverage   73.3596%   72.7393%   -0.6203%     
================================================
  Files          1324       1345        +21     
  Lines        396657     402951      +6294     
================================================
+ Hits         290986     293104      +2118     
- Misses        87110      91234      +4124     
- Partials      18561      18613        +52     
Flag Coverage Δ
integration 27.7921% <37.5000%> (?)
unit 73.3585% <100.0000%> (-0.0011%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9609% <ø> (ø)
br 48.2930% <ø> (-4.3629%) ⬇️

@tiprow
Copy link

tiprow bot commented Sep 6, 2023

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@solotzg solotzg changed the title types: fix convert str -0 to uint types: fix convert str -000?* to uint Sep 6, 2023
@solotzg solotzg changed the title types: fix convert str -000?* to uint types: fix convert str -0000 to uint Sep 6, 2023
@tiprow
Copy link

tiprow bot commented Sep 6, 2023

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Sep 6, 2023

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@solotzg
Copy link
Contributor Author

solotzg commented Sep 6, 2023

/cc @wshwsh12

@ti-chi-bot ti-chi-bot bot requested a review from wshwsh12 September 6, 2023 13:21
Signed-off-by: TONG, Zhigao <[email protected]>
@tiprow
Copy link

tiprow bot commented Sep 7, 2023

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Sep 7, 2023

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@solotzg
Copy link
Contributor Author

solotzg commented Sep 8, 2023

/cc @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested a review from XuHuaiyu September 8, 2023 07:48
types/convert.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 8, 2023
@solotzg solotzg changed the title types: fix convert str -0000 to uint types: fix convert str -000* to uint Sep 8, 2023
@solotzg solotzg changed the title types: fix convert str -000* to uint types: fix convert str -00* to uint Sep 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 8, 2023
@solotzg
Copy link
Contributor Author

solotzg commented Sep 11, 2023

@hawkingrei PTAL

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2023
@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@solotzg: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@solotzg: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2023
@purelind
Copy link
Contributor

Wait for this PR #46712 to be merged first.

@purelind
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6397d47 into pingcap:master Sep 11, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #46871.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 11, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #46872.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 11, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #46873.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 11, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #46874.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 11, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #46875.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 11, 2023
@solotzg solotzg deleted the fix-44359 branch September 11, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect query result
6 participants