Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo,planner,statistics: add OWNERS files in top module folders #46981

Merged
merged 23 commits into from
Apr 9, 2024
Merged

bindinfo,planner,statistics: add OWNERS files in top module folders #46981

merged 23 commits into from
Apr 9, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Sep 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #46969 #46970 #46971

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • None
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • None
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2023
@tiprow
Copy link

tiprow bot commented Sep 14, 2023

Hi @wuhuizuo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

/run-check-issue-triage-complete

@wuhuizuo
Copy link
Contributor Author

/review default

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2023

@wuhuizuo:
This pull request adds OWNERS files in three modules, bindinfo, planner and statistics. OWNERS files are important for defining who is responsible for reviewing and approving changes to specific parts of the codebase.

There are no potential problems in this pull request, as it is a simple addition of OWNERS files.

No fixing suggestions are needed.

In response to this:

/review default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo wuhuizuo marked this pull request as ready for review September 14, 2023 09:14
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@wuhuizuo
Copy link
Contributor Author

/cc @chrysan @fixdb @winoros @qw4990

hawkingrei
hawkingrei reviewed Sep 14, 2023
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
@wuhuizuo
Copy link
Contributor Author

/sig ?

@wuhuizuo
Copy link
Contributor Author

/component ?

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2023

@wuhuizuo: The label(s) component/? cannot be applied, because the repository doesn't have them.

In response to this:

/component ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Contributor Author

/sig ?

1 similar comment
@wuhuizuo
Copy link
Contributor Author

/sig ?

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2023

@wuhuizuo: The label(s) sig/? cannot be applied, because the repository doesn't have them.

In response to this:

/sig ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Contributor Author

/sig planner

@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Sep 14, 2023
Rustin170506
Rustin170506 requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I have permission to review the code of these modules? If I don't have it, why take away my permission?

@winoros
Copy link
Member

winoros commented Sep 14, 2023

Do I have permission to review the code of these modules? If I don't have it, why take away my permission?

It should be like the current sessionctx and config folders. The merge permission is restricted. The review(+1) permission is the same.

@winoros
Copy link
Member

winoros commented Sep 14, 2023

What's the future process of changing the three owner files?

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 14, 2023 •
edited
Loading

What's the future process of changing the three owner files?

@winoros

  • Create pull request to update OWNERS_ALIASES file when need to update members.
  • Add OWNERS files to children folders by teams if they need.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 7, 2024

/uncc chrysan

@ti-chi-bot ti-chi-bot bot removed the request for review from chrysan April 7, 2024 01:58
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 7, 2024

/hold

wait for all members of sig-approvers-planner become committees.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2024
wuhuizuo
wuhuizuo commented Apr 7, 2024
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 7, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2024
fixdb
fixdb approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2023-09-14 11:25:24.75034198 +0000 UTC m=+171090.717930032: ✖️🔁 reset by hi-rustin.
  • 2024-04-09 06:38:41.072044247 +0000 UTC m=+944382.599584784: ☑️ agreed by fixdb.
  • 2024-04-09 06:40:35.51912825 +0000 UTC m=+944497.046668812: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 510f44f into pingcap:master Apr 9, 2024
3 of 5 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52443.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
Merged
14 tasks
@wuhuizuo wuhuizuo deleted the wuhuizuo/issue46969 branch April 9, 2024 13:07
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 9, 2024

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-8.1: #52459.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
Merged
14 tasks
This was referenced Apr 10, 2024
Closed
Closed
ti-chi-bot bot pushed a commit that referenced this pull request Nov 13, 2024
@ti-chi-bot
bindinfo,planner,statistics: add OWNERS files in top module folders (…
9d5e282 
…#46981) (#52443)

close #46969
ti-chi-bot bot pushed a commit that referenced this pull request Nov 13, 2024
@ti-chi-bot
bindinfo,planner,statistics: add OWNERS files in top module folders (…
2aacd77 
…#46981) (#52459)

close #46969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@fixdb fixdb fixdb approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@winoros winoros Awaiting requested review from winoros

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add OWNERS file for pkg/bindinfo folder
6 participants
@wuhuizuo @winoros @Rustin170506 @ti-chi-bot @fixdb @hawkingrei