Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: create a separate unified function to update variables for statistics sctx #47051

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 18, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary: planner: create a separate unified function to update variables for statistics sctx

What is changed and how it works?

planner: create a separate unified function to update variables for statistics sctx

The goal is to use this function to remove h.mu.ctx later on:

fe247aa0-da36-4d27-bb15-2ec1a85c8c98

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 requested a review from a team as a code owner September 18, 2023 06:37
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 18, 2023
@tiprow
Copy link

tiprow bot commented Sep 18, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #47051 (a6b7bd1) into master (35add6f) will decrease coverage by 0.3390%.
Report is 3 commits behind head on master.
The diff coverage is 60.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47051        +/-   ##
================================================
- Coverage   73.0786%   72.7396%   -0.3390%     
================================================
  Files          1336       1357        +21     
  Lines        398226     404683      +6457     
================================================
+ Hits         291018     294365      +3347     
- Misses        88467      91664      +3197     
+ Partials      18741      18654        -87     
Flag Coverage Δ
integration 30.5247% <49.0909%> (?)
unit 73.1179% <60.0000%> (+0.0393%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9980% <ø> (+0.0107%) ⬆️
br 48.8713% <ø> (-4.0687%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2023
@Rustin170506 Rustin170506 self-requested a review September 18, 2023 07:36
@hawkingrei hawkingrei self-requested a review September 18, 2023 07:37
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 18, 2023
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-18 08:03:07.932552769 +0000 UTC m=+504553.900140810: ☑️ agreed by winoros.
  • 2023-09-18 08:09:26.356467238 +0000 UTC m=+504932.324055286: ☑️ agreed by hi-rustin.

@easonn7
Copy link

easonn7 commented Sep 18, 2023

/approve

There is no sysvar change.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, hi-rustin, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants