Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: reuse datum when to buildHist #47371

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 28, 2023

What problem does this PR solve?

Issue Number: ref #47275

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2023
@hawkingrei hawkingrei changed the title statistics: reuse datum when to buildhists statistics: reuse datum when to buildHist Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #47371 (e23d2de) into master (a7d0a3a) will increase coverage by 0.3893%.
Report is 10 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47371        +/-   ##
================================================
+ Coverage   72.3231%   72.7125%   +0.3893%     
================================================
  Files          1352       1373        +21     
  Lines        400815     407271      +6456     
================================================
+ Hits         289882     296137      +6255     
- Misses        91754      92341       +587     
+ Partials      19179      18793       -386     
Flag Coverage Δ
integration 38.7008% <100.0000%> (?)
unit 72.3153% <100.0000%> (-0.0078%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.7544% <ø> (-0.0108%) ⬇️
br 48.7421% <ø> (-4.3579%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qw4990,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-07 01:47:30.734762533 +0000 UTC m=+844048.321872684: ☑️ agreed by qw4990.
  • 2023-10-07 03:45:14.181391041 +0000 UTC m=+851111.768501183: ☑️ agreed by time-and-fate.

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 753520a into pingcap:master Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants