Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: reduce the copy when to merge global status #47372

Merged
merged 3 commits into from
Oct 7, 2023
Merged

statistics: reduce the copy when to merge global status #47372

merged 3 commits into from
Oct 7, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 28, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #47219

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Sep 28, 2023
@hawkingrei
Copy link
Member Author

/retest

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #47372 (72c1fea) into master (753520a) will increase coverage by 0.4666%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47372        +/-   ##
================================================
+ Coverage   72.2961%   72.7627%   +0.4666%     
================================================
  Files          1352       1373        +21     
  Lines        400865     407494      +6629     
================================================
+ Hits         289810     296504      +6694     
- Misses        91856      92212       +356     
+ Partials      19199      18778       -421
Flag Coverage Δ
integration 38.6760% <88.2352%> (?)
unit 72.3362% <100.0000%> (+0.0401%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.7544% <ø> (-0.0108%) ⬇️
br 49.0946% <ø> (-3.9896%) ⬇️

@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2023
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from qw4990 October 7, 2023 06:36
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 7, 2023
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-07 06:47:34.904691308 +0000 UTC m=+862052.491801439: ☑️ agreed by winoros.
  • 2023-10-07 07:28:16.809115812 +0000 UTC m=+864494.396225957: ☑️ agreed by qw4990.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0b0032b into pingcap:master Oct 7, 2023
@hawkingrei hawkingrei deleted the avoid_copy_0928 branch October 7, 2023 09:08
@L-maple
Copy link
Contributor

L-maple commented Dec 3, 2024

@hawkingrei Hi, I try to understand the global stats recently.
I see this PR, but do not understand why cache is useless. In my opinion, cache can reduce load stats from storage.
For example, a partitioned table(10 partitions) has 4 columns and 4 indexes.
Before, 10 loadStats. After, 5 * 10 loadStats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @L-maple @qw4990 @winoros