analyze: merge task and send task concurrently #47379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47379 +/- ##
================================================
+ Coverage 72.3183% 72.8807% +0.5624%
================================================
Files 1352 1376 +24
Lines 400846 409270 +8424
================================================
+ Hits 289885 298279 +8394
- Misses 91782 92082 +300
+ Partials 19179 18909 -270
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hawkingrei
changed the title
winoros
approved these changes
Oct 10, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
lance6716
reviewed
Oct 10, 2023
qw4990
reviewed
Oct 10, 2023
| mergeWorkerPanicCnt++ | ||
| mergeEg, mergeCtx := errgroup.WithContext(context.Background()) | ||
| mergeEg.Go(func() (err error) { | ||
| for mergeWorkerPanicCnt < statsConcurrency { |
There was a problem hiding this comment.
Should we recover it? Otherwise, if it panics, the whole process will exit.
qw4990
approved these changes
Oct 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #47275
Problem Summary:
What is changed and how it works?
Start the merge operation early to reduce memory consumption.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.