Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: encapsulate session stats collection logic into a single dedicated structure #47512

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Oct 10, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary: planner: encapsulate session stats collection logic into a single dedicated structure

No logical change, just refactor.

What is changed and how it works?

planner: encapsulate session stats collection logic into a single dedicated structure

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2023
@tiprow
Copy link

tiprow bot commented Oct 10, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #47512 (0532c45) into master (9e4922a) will increase coverage by 0.6422%.
Report is 4 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47512        +/-   ##
================================================
+ Coverage   72.1485%   72.7908%   +0.6422%     
================================================
  Files          1354       1374        +20     
  Lines        401261     408509      +7248     
================================================
+ Hits         289504     297357      +7853     
+ Misses        92452      92301       -151     
+ Partials      19305      18851       -454     
Flag Coverage Δ
integration 39.7707% <12.5827%> (?)
unit 72.1451% <100.0000%> (-0.0034%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.6574% <ø> (-0.0108%) ⬇️
br 48.8787% <ø> (-4.3227%) ⬇️

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 10, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Oct 10, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-10 08:05:30.983897401 +0000 UTC m=+1125928.571007547: ☑️ agreed by hawkingrei.
  • 2023-10-10 08:36:20.308886713 +0000 UTC m=+1127777.895996844: ☑️ agreed by time-and-fate.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 10, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Oct 10, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 10, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Oct 10, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 97c7741 into pingcap:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants