Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: reduce the length of channel to avoid OOM #47540

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 11, 2023

What problem does this PR solve?

Issue Number: ref #47275

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Oct 11, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #47540 (c16fd69) into master (ec2731b) will increase coverage by 0.6037%.
Report is 8 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47540        +/-   ##
================================================
+ Coverage   72.1426%   72.7463%   +0.6037%     
================================================
  Files          1353       1374        +21     
  Lines        401327     409017      +7690     
================================================
+ Hits         289528     297545      +8017     
- Misses        92490      92744       +254     
+ Partials      19309      18728       -581     
Flag Coverage Δ
integration 40.4338% <100.0000%> (?)
unit 72.0385% <100.0000%> (-0.1042%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.7077% <ø> (+0.0107%) ⬆️
br 48.8758% <ø> (-4.3196%) ⬇️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-11 06:35:50.282711251 +0000 UTC m=+1206947.869821396: ☑️ agreed by winoros.
  • 2023-10-11 07:24:20.29190279 +0000 UTC m=+1209857.879012936: ☑️ agreed by qw4990.

@hawkingrei
Copy link
Member Author

/retest

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 68b5788 into pingcap:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants