Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: avoid unnecessary copy at CMSketchAndTopNFromProto #47598

Merged
merged 5 commits into from
Oct 17, 2023
Merged

statistics: avoid unnecessary copy at CMSketchAndTopNFromProto #47598

merged 5 commits into from
Oct 17, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #47275

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #47598 (e08b92a) into master (2482a6e) will increase coverage by 0.8433%.
Report is 26 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47598        +/-   ##
================================================
+ Coverage   71.9415%   72.7848%   +0.8433%     
================================================
  Files          1397       1421        +24     
  Lines        404701     411458      +6757     
================================================
+ Hits         291148     299479      +8331     
+ Misses        93958      93129       -829     
+ Partials      19595      18850       -745
Flag Coverage Δ
integration 41.4169% <100.0000%> (?)
unit 71.8941% <100.0000%> (-0.0474%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6897% <ø> (-4.2447%) ⬇️

@hawkingrei
update
08e5706 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested review from winoros and qw4990 October 17, 2023 09:38
hawkingrei
hawkingrei commented Oct 17, 2023
View reviewed changes
pkg/statistics/cmsketch.go
pbTopN := make([]*tipb.CMSketchTopN, 0, len(topNRows))
for _, row := range topNRows {
data := make([]byte, len(row.GetBytes(0)))
copy(data, row.GetBytes(0))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this copy is unnecessary.

@hawkingrei
update
d9a6d01 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
fc836da 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
e08b92a 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-17 10:05:34.532111826 +0000 UTC m=+1737932.119221971: ☑️ agreed by winoros.
  • 2023-10-17 10:23:12.01734147 +0000 UTC m=+1738989.604451633: ☑️ agreed by crazycs520.

elsa0520
elsa0520 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, elsa0520, qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [crazycs520,qw4990,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit f69f37a into pingcap:master Oct 17, 2023
@hawkingrei hawkingrei deleted the topn_proto branch October 17, 2023 10:47
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #47724.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 17, 2023
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 17, 2023
@hawkingrei @ti-chi-bot
statistics: avoid unnecessary copy at CMSketchAndTopNFromProto (pingc…
02084d0 
…ap#47598)

ref pingcap#47275
ti-chi-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@ti-chi-bot
statistics: avoid unnecessary copy at CMSketchAndTopNFromProto (#47598)…
ad63329 
… (#47724)

ref #47275
@hawkingrei
Copy link
Member Author

/cherrypick release-7.1
/cherrypick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2023
Closed
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #49448.

In response to this:

/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 14, 2023
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#47598
2d5b0e4 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2023
Open
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #49449.

In response to this:

/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 14, 2023
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#47598
1cbc90d 
Signed-off-by: ti-chi-bot <[email protected]>
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
@hawkingrei @wuhuizuo
statistics: avoid unnecessary copy at CMSketchAndTopNFromProto (pingc…
76d71f7 
…ap#47598)

ref pingcap#47275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsa0520 elsa0520 elsa0520 approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hawkingrei @ti-chi-bot @qw4990 @winoros @crazycs520 @elsa0520