Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: move some functions into global stats #47669

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 16, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei changed the title statstics: move some function into global status. statstics: move some function into global stats Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Oct 16, 2023
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested a review from qw4990 October 16, 2023 09:16
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #47669 (5dc9b43) into master (34bc3a1) will increase coverage by 0.8630%.
Report is 5 commits behind head on master.
The diff coverage is 36.8421%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47669        +/-   ##
================================================
+ Coverage   71.9564%   72.8194%   +0.8629%     
================================================
  Files          1396       1419        +23     
  Lines        404738     411154      +6416     
================================================
+ Hits         291235     299400      +8165     
+ Misses        93906      92911       -995     
+ Partials      19597      18843       -754     
Flag Coverage Δ
integration 41.3254% <6.3157%> (?)
unit 71.9200% <36.8421%> (-0.0364%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6761% <ø> (-4.2775%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2023
Signed-off-by: Weizhen Wang <[email protected]>
@Rustin170506 Rustin170506 changed the title statstics: move some function into global stats statistics: move some functions into global stats Oct 16, 2023
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 09:20:45.414849338 +0000 UTC m=+1648843.001959482: ☑️ agreed by qw4990.
  • 2023-10-16 09:48:06.754571922 +0000 UTC m=+1650484.341682052: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 54bc3a5 into pingcap:master Oct 16, 2023
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants