Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: update client-go to fix #35418 #47951

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Oct 25, 2023

What problem does this PR solve?

Issue Number: close #35418

Problem Summary:

What is changed and how it works?

update client-go to fix #35418

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • tests added in client-go side

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the bug that TiFlash load may not be balanced if some TiFlash nodes is back to up after down for a long time. 

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@tiprow
Copy link

tiprow bot commented Oct 25, 2023

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #47951 (bc3e8a2) into master (2a4f569) will increase coverage by 1.0555%.
Report is 1 commits behind head on master.
The diff coverage is 80.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47951        +/-   ##
================================================
+ Coverage   71.7625%   72.8181%   +1.0555%     
================================================
  Files          1401       1424        +23     
  Lines        405664     412040      +6376     
================================================
+ Hits         291115     300040      +8925     
+ Misses        94814      93109      -1705     
+ Partials      19735      18891       -844     
Flag Coverage Δ
integration 41.8539% <80.0000%> (?)
unit 71.7682% <80.0000%> (+0.0056%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7573% <ø> (-4.2705%) ⬇️

@windtalker
Copy link
Contributor Author

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 25, 2023

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@windtalker
Copy link
Contributor Author

/test build

@tiprow
Copy link

tiprow bot commented Oct 25, 2023

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 25, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuHuaiyu, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-25 05:05:54.449889177 +0000 UTC m=+2411152.036999335: ☑️ agreed by you06.
  • 2023-10-25 05:33:35.517104195 +0000 UTC m=+2412813.104214341: ☑️ agreed by XuHuaiyu.

@tiprow
Copy link

tiprow bot commented Oct 25, 2023

@windtalker: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test bc3e8a2 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit f3dfd89 into pingcap:master Oct 25, 2023
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 27, 2023
@hawkingrei
Copy link
Member

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #48101.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@windtalker windtalker deleted the update_client_go_2 branch December 28, 2023 09:27
rleungx pushed a commit to rleungx/tidb that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants