types,*: remove the dependency stmtctx from types package.
#48108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangKeao
added
the
release-note-none
ti-chi-bot
bot
added
the
size/XXL
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48108 +/- ##
================================================
+ Coverage 71.5679% 73.4632% +1.8953%
================================================
Files 1401 1425 +24
Lines 405936 418190 +12254
================================================
+ Hits 290520 307216 +16696
+ Misses 95598 92117 -3481
+ Partials 19818 18857 -961
Flags with carried forward coverage won't be shown. Click here to find out more.
|
YangKeao
force-pushed
the
clear-types-stmtctx
branch
from
84b9c1b to
304f517
Compare
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
clear-types-stmtctx
branch
from
304f517 to
14f1e6e
Compare
hawkingrei
approved these changes
Oct 31, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
lcwangchao
approved these changes
Oct 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lcwangchao, windtalker, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
The deadlock is not related with current PR. I've recorded them in an issue: #48178 /retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #48080
Problem Summary:
This PR removes the dependency
stmtctxfromtypespackages.What is changed and how it works?
stmtctxdependency is removed fromtypespackage.types/contexthas been merged withtypes. The existing alias is removed.Check List
Tests
Like other refractor, this PR is covered by existing tests.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.