Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statstics: remove useless cache #48650

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 16, 2023

What problem does this PR solve?

Issue Number: ref #47275

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-tests-checked labels Nov 16, 2023
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 16, 2023
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 16, 2023
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested review from qw4990, tiancaiamao and Rustin170506 and removed request for tiancaiamao November 16, 2023 10:58
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 16, 2023
Copy link

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-16 10:53:12.297322074 +0000 UTC m=+4332789.884432220: ☑️ agreed by winoros.
  • 2023-11-16 11:08:01.927809888 +0000 UTC m=+4333679.514920032: ☑️ agreed by hi-rustin.

Signed-off-by: Weizhen Wang <[email protected]>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #48650 (72d3d19) into master (3f1c698) will increase coverage by 1.4643%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48650        +/-   ##
================================================
+ Coverage   71.2086%   72.6729%   +1.4643%     
================================================
  Files          1360       1384        +24     
  Lines        403770     410418      +6648     
================================================
+ Hits         287519     298263     +10744     
+ Misses        96323      93264      -3059     
+ Partials      19928      18891      -1037     
Flag Coverage Δ
integration 43.4933% <100.0000%> (?)
unit 71.2215% <100.0000%> (+0.0128%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7948% <ø> (-4.2790%) ⬇️

Copy link

ti-chi-bot bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hi-rustin,qw4990,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit fb58ab7 into pingcap:master Nov 16, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48651.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants