Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix data race of Column.GeneratedExpr (#48888) #48924

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48888

What problem does this PR solve?

Issue Number: close #44919, close #48191.

Problem Summary:

What changed and how does it work?

Add Clone() and Internal() method for Column.GeneratedExpr field.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    $ go test -race github.com/pingcap/tidb/pkg/ddl/ingest -test.run ^TestAddIndexIngestMultiSchemaChange$ --tags=intest
    ok      github.com/pingcap/tidb/pkg/ddl/ingest  3.772s
    
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@069631e). Click here to learn what that means.
The diff coverage is 64.2857%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #48924   +/-   ##
================================================
  Coverage               ?   72.7417%           
================================================
  Files                  ?       1404           
  Lines                  ?     413078           
  Branches               ?          0           
================================================
  Hits                   ?     300480           
  Misses                 ?      93051           
  Partials               ?      19547           
Flag Coverage Δ
unit 72.7417% <64.2857%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4224% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 1, 2024
Copy link

ti-chi-bot bot commented Feb 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-01 08:31:03.575993052 +0000 UTC m=+1640705.140290756: ☑️ agreed by hawkingrei.
  • 2024-02-01 09:17:25.589625648 +0000 UTC m=+1643487.153923350: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 19, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2024
@Benjamin2037
Copy link
Collaborator

/retest

1 similar comment
@Benjamin2037
Copy link
Collaborator

/retest

Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, hawkingrei, tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Benjamin2037
Copy link
Collaborator

/retest

2 similar comments
@Benjamin2037
Copy link
Collaborator

/retest

@Benjamin2037
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1ec94fb into pingcap:release-7.5 Feb 20, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants