-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix data race of Column.GeneratedExpr (#48888) #48924
*: fix data race of Column.GeneratedExpr (#48888) #48924
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #48924 +/- ##
================================================
Coverage ? 72.7417%
================================================
Files ? 1404
Lines ? 413078
Branches ? 0
================================================
Hits ? 300480
Misses ? 93051
Partials ? 19547
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, hawkingrei, tangenta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
This is an automated cherry-pick of #48888
What problem does this PR solve?
Issue Number: close #44919, close #48191.
Problem Summary:
What changed and how does it work?
Add
Clone()
andInternal()
method forColumn.GeneratedExpr
field.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.