Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add benchmark for BuildHistAndTopN with low NDV #48961

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 28, 2023

What problem does this PR solve?

Issue Number: ref #47275

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Nov 28, 2023
@hawkingrei hawkingrei removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #48961 (e26908b) into master (c741119) will increase coverage by 1.6487%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48961        +/-   ##
================================================
+ Coverage   70.9941%   72.6428%   +1.6487%     
================================================
  Files          1368       1389        +21     
  Lines        404987     411129      +6142     
================================================
+ Hits         287517     298656     +11139     
+ Misses        97448      93612      -3836     
+ Partials      20022      18861      -1161     
Flag Coverage Δ
integration 43.6479% <ø> (?)
unit 70.9941% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8110% <ø> (-4.2698%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-28 08:46:57.397274964 +0000 UTC m=+912446.062501160: ☑️ agreed by winoros.
  • 2023-11-28 08:48:24.326912404 +0000 UTC m=+912532.992138600: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit ba608a9 into pingcap:master Nov 28, 2023
@hawkingrei hawkingrei deleted the add_benchmark_for branch November 28, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants