Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix DATA RACE caused by TestCaptureWildcardFilter (#49092) #49094

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49092

What problem does this PR solve?

Issue Number: close #49088

Problem Summary: planner: fix DATA RACE caused by TestCaptureWildcardFilter

What changed and how does it work?

fix DATA RACE caused by TestCaptureWildcardFilter

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 1, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 04:04:15.6943496 +0000 UTC m=+329944.441972742: ☑️ agreed by fixdb.
  • 2024-02-20 04:22:54.701547373 +0000 UTC m=+331063.449170483: ☑️ agreed by qw4990.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@069631e). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #49094   +/-   ##
================================================
  Coverage               ?   72.4944%           
================================================
  Files                  ?       1404           
  Lines                  ?     410724           
  Branches               ?          0           
================================================
  Hits                   ?     297752           
  Misses                 ?      93380           
  Partials               ?      19592           
Flag Coverage Δ
unit 72.4944% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3314% <0.0000%> (?)

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test check-dev-2

Copy link

ti-chi-bot bot commented Feb 20, 2024

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-7.5/ghpr_build
  • pingcap/tidb/release-7.5/ghpr_check
  • pingcap/tidb/release-7.5/ghpr_check2
  • pingcap/tidb/release-7.5/ghpr_mysql_test
  • pingcap/tidb/release-7.5/ghpr_unit_test

In response to this:

/test check-dev-2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test all

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev-2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/retest

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/retest

@wuhuizuo
Copy link
Contributor

/hold
wait for merging of #51164

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@wuhuizuo
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 ffb0007 link unknown /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test check-dev2

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 75b2e1f into pingcap:release-7.5 Feb 20, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants