Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: update the pd client for release-7.1 #49342

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Dec 11, 2023

What problem does this PR solve?

Issue Number: close tikv/pd#7509

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Sorry, something went wrong.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Dec 11, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 11, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Dec 11, 2023
@nolouch nolouch requested review from glorv and CabinfeverB December 11, 2023 10:31

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: nolouch <[email protected]>
@nolouch
Copy link
Member Author

nolouch commented Dec 11, 2023

/test unit-test

Copy link

tiprow bot commented Dec 11, 2023

@nolouch: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 11, 2023
Copy link

ti-chi-bot bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CabinfeverB, glorv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 11, 2023
Copy link

ti-chi-bot bot commented Dec 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-11 10:46:51.977886299 +0000 UTC m=+266703.015113211: ☑️ agreed by glorv.
  • 2023-12-11 10:48:00.188514531 +0000 UTC m=+266771.225741456: ☑️ agreed by CabinfeverB.

fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: nolouch <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2023
fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@c870a52). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #49342   +/-   ##
================================================
  Coverage               ?   73.3957%           
================================================
  Files                  ?       1207           
  Lines                  ?     378552           
  Branches               ?          0           
================================================
  Hits                   ?     277841           
  Misses                 ?      82955           
  Partials               ?      17756           

@ti-chi-bot ti-chi-bot bot merged commit 126cf52 into pingcap:release-7.1 Dec 11, 2023
2 checks passed
@nolouch nolouch deleted the update-cli-7.1 branch December 11, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants