Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statsitics: clear the fmsketch's map correctly #49379

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 12, 2023

What problem does this PR solve?

Issue Number: close #49381

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

before

image

after:

image

The new one has better CPU usage.

image

the left one is the old, the right one is the new.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #49379 (7d902ad) into master (49f89a9) will increase coverage by 0.7929%.
Report is 6 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49379        +/-   ##
================================================
+ Coverage   71.0490%   71.8420%   +0.7929%     
================================================
  Files          1368       1412        +44     
  Lines        401711     415620     +13909     
================================================
+ Hits         285412     298590     +13178     
- Misses        96443      98198      +1755     
+ Partials      19856      18832      -1024     
Flag Coverage Δ
integration 43.8429% <100.0000%> (?)
unit 71.0483% <ø> (-0.0008%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.9211% <ø> (-4.9723%) ⬇️

@hawkingrei hawkingrei changed the title statsitics: right clear the fmsketch's map statsitics: clear the fmsketch's map correctly Dec 12, 2023
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2023
Copy link

ti-chi-bot bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2023
Copy link

ti-chi-bot bot commented Dec 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-12 10:38:29.550826199 +0000 UTC m=+352600.588053126: ☑️ agreed by elsa0520.
  • 2023-12-12 10:44:45.121335909 +0000 UTC m=+352976.158562854: ☑️ agreed by winoros.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 24606a4 into pingcap:master Dec 12, 2023
16 checks passed
@hawkingrei hawkingrei deleted the clear_at_here branch December 13, 2023 04:04
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #49402.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

right clear the fmsketch cache
4 participants