disttask: init node meta inside domain #49996

D3Hunter · 2024-01-03T03:19:01Z

What problem does this PR solve?

Issue Number: close #49990

Problem Summary:

What changed and how does it work?

we init node meta inside domain, as create task requires at least 1 managed node inited after #49875 merged

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-01-03T03:19:31Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2024-01-03T03:20:15Z

/run-check-issue-triage-complete

ywqzzy · 2024-01-03T03:26:03Z

pkg/disttask/framework/taskexecutor/manager.go

@@ -132,13 +132,15 @@ func (m *Manager) initMeta() (err error) {
 	return err
 }

+// InitMeta initializes the meta of the Manager.
+// not a must-success step before start manager, manager will try to init meta periodically.
+func (m *Manager) InitMeta() error {


Just rename initMeta to InitMeta？

it's named Init in the begin, but it's misleading to Start even Init failed, so renamed to InitMeta

will leave it for now

ywqzzy

Rest LGTM

codecov · 2024-01-03T03:33:53Z

Codecov Report

Merging #49996 (745b6fe) into master (999f599) will decrease coverage by 3.1323%.
Report is 16 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #49996        +/-   ##
================================================
- Coverage   72.0631%   68.9309%   -3.1323%     
================================================
  Files          1438       1440         +2     
  Lines        345762     410775     +65013     
================================================
+ Hits         249167     283151     +33984     
- Misses        76457     108690     +32233     
+ Partials      20138      18934      -1204

Flag	Coverage Δ
integration	`44.4360% <50.0000%> (?)`
unit	`72.0618% <ø> (-0.0013%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`56.3129% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`43.8546% <ø> (-7.8482%)`	⬇️

ti-chi-bot · 2024-01-03T08:46:04Z

[LGTM Timeline notifier]

Timeline:

2024-01-03 03:26:22.351108976 +0000 UTC m=+2227473.388335905: ☑️ agreed by ywqzzy.
2024-01-03 08:46:03.652735401 +0000 UTC m=+2246654.689962327: ☑️ agreed by tangenta.

ti-chi-bot · 2024-01-03T08:46:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/disttask/OWNERS~~ [lance6716,tangenta,ywqzzy]
~~pkg/domain/OWNERS~~ [lance6716,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2024-01-03T08:58:57Z

/retest

D3Hunter · 2024-01-03T08:59:11Z

/test tiprow_fast_test

ti-chi-bot · 2024-01-03T08:59:13Z

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-01-03T08:59:21Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-01-03T08:59:32Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2024-01-03T08:59:32Z

/ok-to-test

hawkingrei · 2024-01-03T09:05:03Z

/unhold

D3Hunter · 2024-01-03T10:14:24Z

/retest

close pingcap#49990

D3Hunter added 2 commits January 3, 2024 11:15

init meta inside domain

323d893

change

745b6fe

ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2024

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Jan 3, 2024

ywqzzy reviewed Jan 3, 2024

View reviewed changes

ywqzzy approved these changes Jan 3, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 3, 2024

tangenta approved these changes Jan 3, 2024

View reviewed changes

ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 3, 2024

lance6716 approved these changes Jan 3, 2024

View reviewed changes

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 3, 2024

ti-chi-bot bot merged commit 49dfd93 into pingcap:master Jan 3, 2024
18 checks passed

D3Hunter deleted the fix-flaky-case branch January 3, 2024 11:00

AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024

disttask: init node meta inside domain (pingcap#49996)

d6464e8

close pingcap#49990

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

disttask: init node meta inside domain #49996

disttask: init node meta inside domain #49996

D3Hunter commented Jan 3, 2024 •

edited

Loading

tiprow bot commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

ywqzzy Jan 3, 2024

D3Hunter Jan 3, 2024

ywqzzy left a comment

codecov bot commented Jan 3, 2024 •

edited

Loading

ti-chi-bot bot commented Jan 3, 2024

ti-chi-bot bot commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

ti-chi-bot bot commented Jan 3, 2024

tiprow bot commented Jan 3, 2024

tiprow bot commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

hawkingrei commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

disttask: init node meta inside domain #49996

disttask: init node meta inside domain #49996

Conversation

D3Hunter commented Jan 3, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

ywqzzy Jan 3, 2024

Choose a reason for hiding this comment

D3Hunter Jan 3, 2024

Choose a reason for hiding this comment

ywqzzy left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 3, 2024 • edited Loading

Codecov Report

ti-chi-bot bot commented Jan 3, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

ti-chi-bot bot commented Jan 3, 2024

tiprow bot commented Jan 3, 2024

tiprow bot commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

hawkingrei commented Jan 3, 2024

D3Hunter commented Jan 3, 2024

D3Hunter commented Jan 3, 2024 •

edited

Loading

codecov bot commented Jan 3, 2024 •

edited

Loading