Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add new row panel for tidb query #50086

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Jan 4, 2024

What problem does this PR solve?

Issue Number: ref #49318

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
image

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jan 4, 2024
Copy link

ti-chi-bot bot commented Jan 4, 2024

Hi @bufferflies. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jan 4, 2024

Hi @bufferflies. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bufferflies
Copy link
Contributor Author

/cc @glorv @nolouch

@ti-chi-bot ti-chi-bot bot requested review from glorv and nolouch January 4, 2024 10:25
@nolouch
Copy link
Member

nolouch commented Jan 5, 2024

Can it select a group variable?

@nolouch
Copy link
Member

nolouch commented Jan 5, 2024

and seems here no group result:
image

@bufferflies
Copy link
Contributor Author

Can it select a group variable?
yes, I have add new select.

image

@bufferflies
Copy link
Contributor Author

and seems here no group result: image

In this picture, I use the root role to run some ddl, the root doesn't belong any resource group.

@bufferflies
Copy link
Contributor Author

and seems here no group result: image

In this picture, I use the root role to run some ddl, the root doesn't belong any resource group.

dnT4hg4j4o
fixed

Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/metrics/grafana/tidb_resource_control.json Outdated Show resolved Hide resolved
pkg/metrics/grafana/tidb_resource_control.json Outdated Show resolved Hide resolved
pkg/metrics/grafana/tidb_resource_control.json Outdated Show resolved Hide resolved
Signed-off-by: bufferflies <[email protected]>
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-tests-checked labels Jan 9, 2024
@nolouch
Copy link
Member

nolouch commented Jan 9, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #50086 (ac1d49c) into master (e3abcbb) will decrease coverage by 14.6648%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50086         +/-   ##
=================================================
- Coverage   70.0692%   55.4045%   -14.6648%     
=================================================
  Files          1443       1554        +111     
  Lines        419903     586988     +167085     
=================================================
+ Hits         294223     325218      +30995     
- Misses       105398     239040     +133642     
- Partials      20282      22730       +2448     
Flag Coverage Δ
integration 36.6130% <100.0000%> (?)
unit 69.9937% <100.0000%> (-0.0756%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.4385% <ø> (+5.7145%) ⬆️

Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-09 08:24:14.861383348 +0000 UTC m=+345244.445637037: ☑️ agreed by nolouch.
  • 2024-01-10 04:22:09.462641006 +0000 UTC m=+417119.046894678: ☑️ agreed by glorv.

@nolouch
Copy link
Member

nolouch commented Jan 10, 2024

/retest-required

@glorv
Copy link
Contributor

glorv commented Jan 10, 2024

    data_feature_usage_test.go:508: 
        	Error Trace:	pkg/telemetry/data_feature_usage_test.go:508
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 0
        	Test:       	TestTxnSavepointUsageInfo

@bufferflies there is a unit test failure.

Signed-off-by: bufferflies <[email protected]>
@bufferflies
Copy link
Contributor Author

/label needs-cherry-pick-release-7.6

@bufferflies
Copy link
Contributor Author

/label needs-cherry-pick-release-7.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 11, 2024
@bufferflies
Copy link
Contributor Author

/retest

@bufferflies
Copy link
Contributor Author

/test tiprow_fast_test

Copy link

ti-chi-bot bot commented Jan 11, 2024

@bufferflies: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pull-integration-ddl-test
  • /test pull-lightning-integration-test
  • /test pull-mysql-client-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test canary-notify-when-compatibility-sections-changed
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
  • pingcap/tidb/pull_integration_ddl_test
  • pingcap/tidb/pull_mysql_client_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jan 11, 2024

@bufferflies: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test ac1d49c link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 190488d into pingcap:master Jan 11, 2024
20 of 22 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50319.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #50321.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 11, 2024
@bufferflies bufferflies deleted the resource_panel branch January 12, 2024 01:08
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 18, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 20, 2024
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Apr 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52705.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.6 ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants