Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add connection and fail metrics by resource group name (#49424) #50124

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49424

What problem does this PR solve?

Issue Number: ref #49318

Problem Summary:

What changed and how does it work?

Check List

Tests

image
  • I checked and no code files have been changed.

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 5, 2024
Signed-off-by: bufferflies <[email protected]>
@bufferflies
Copy link
Contributor

/cherry-pick-invite

1 similar comment
@bufferflies
Copy link
Contributor

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@bufferflies you're not a member of org pingcap

@bufferflies
Copy link
Contributor

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@bufferflies you're already a collaborator in repo ti-chi-bot/tidb

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved and removed approved labels Jan 7, 2024
Signed-off-by: bufferflies <[email protected]>
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@b0860b9). Click here to learn what that means.
The diff coverage is 88.6597%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #50124   +/-   ##
================================================
  Coverage               ?   71.9737%           
================================================
  Files                  ?       1403           
  Lines                  ?     407261           
  Branches               ?          0           
================================================
  Hits                   ?     293121           
  Misses                 ?      94416           
  Partials               ?      19724           
Flag Coverage Δ
unit 71.9737% <88.6597%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2929% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-07 11:36:03.038793758 +0000 UTC m=+183952.623047446: ☑️ agreed by AilinKid.
  • 2024-01-11 09:31:18.169457467 +0000 UTC m=+522067.753711139: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 11, 2024
@nolouch
Copy link
Member

nolouch commented Jan 11, 2024

ptal @tangenta

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2024
@glorv
Copy link
Contributor

glorv commented Feb 19, 2024

/retest

Copy link

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, BornChanger, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 24a9caa into pingcap:release-7.5 Feb 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants