Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix the const prop over ENUM type (#50208) #50273

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50208

What problem does this PR solve?

Issue Number: close #49440

Problem Summary:

ENUM is a hybrid type and has two possible evaluation ways.

This pull give a correct behavior for the enum and disables the propagation for other two hybrid type SET and BIT.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Do the right constant propagation when the column is a ENUM

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 10, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 22, 2024
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:16:50.063373883 +0000 UTC m=+863498.810997009: ☑️ agreed by fixdb.
  • 2024-02-26 11:23:19.826551491 +0000 UTC m=+874688.574174603: ☑️ agreed by winoros.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@061a7da). Click here to learn what that means.
The diff coverage is 51.1111%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50273   +/-   ##
================================================
  Coverage               ?   73.4354%           
================================================
  Files                  ?       1209           
  Lines                  ?     378982           
  Branches               ?          0           
================================================
  Hits                   ?     278307           
  Misses                 ?      82921           
  Partials               ?      17754           

@winoros
Copy link
Member

winoros commented Feb 27, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 5cc5a43 into pingcap:release-7.1 Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants