-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conn, util: make opentracing
work again
#50551
Conversation
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50551 +/- ##
=================================================
- Coverage 70.2609% 55.6013% -14.6597%
=================================================
Files 1452 1563 +111
Lines 420451 587833 +167382
=================================================
+ Hits 295413 326843 +31430
- Misses 104700 238070 +133370
- Partials 20338 22920 +2582
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold |
/unhold |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #50508
Problem Summary: Caused by #40825, miss root span for opentracing tools.
What changed and how does it work?
Check List
Tests
Start a TiDB cluster as
opentracing.enable
not work after v7.1.0 #50508 said, and use JaegerUI to get trace info success.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.