Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log backup: reset store grpc connection when encounter error (#50539) #50703

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50539

What problem does this PR solve?

Issue Number: close #50445
Problem Summary:
advancer will cache the store grpc connection at first time connect to TiKV. This usually works well when TiKV normal scale-out/in or deploy with a domain name. but in some cases. when deploy TiKV cluster with IP address and IP changed.
the cached grpc connection will broken.

What changed and how does it work?

Disable the cached grpc connection when encounter error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that TiKV IP address changed on same store makes log backup stuck.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@abe9974). Click here to learn what that means.
The diff coverage is 42.8571%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50703   +/-   ##
================================================
  Coverage               ?   73.8442%           
================================================
  Files                  ?       1209           
  Lines                  ?     382183           
  Branches               ?          0           
================================================
  Hits                   ?     282220           
  Misses                 ?      82219           
  Partials               ?      17744           

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 23, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-23 10:31:07.018513228 +0000 UTC m=+612355.766136340: ☑️ agreed by BornChanger.
  • 2024-02-26 08:13:54.532916232 +0000 UTC m=+863323.280539328: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit a7ec476 into pingcap:release-7.1 Feb 26, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants