Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: add missing instance filter in tidb_summary.json #51002

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Feb 6, 2024

What problem does this PR solve?

Issue Number: close #51001

Problem Summary:

What changed and how does it work?

Add the missing instance label to make Grafana more accurate.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 6, 2024
Copy link

ti-chi-bot bot commented Feb 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jackysp jackysp requested a review from you06 February 6, 2024 07:47
Copy link

tiprow bot commented Feb 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2024
@jackysp jackysp marked this pull request as ready for review February 6, 2024 07:48
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Merging #51002 (ed7c248) into master (f0a26dd) will increase coverage by 2.0506%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51002        +/-   ##
================================================
+ Coverage   70.5780%   72.6286%   +2.0506%     
================================================
  Files          1467       1467                
  Lines        434825     434842        +17     
================================================
+ Hits         306891     315820      +8929     
+ Misses       108687      99069      -9618     
- Partials      19247      19953       +706     
Flag Coverage Δ
integration 48.9461% <ø> (?)
unit 70.2889% <ø> (-0.1019%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1120% <ø> (-0.1820%) ⬇️
parser ∅ <ø> (∅)
br 51.1612% <ø> (+5.4161%) ⬆️

@jackysp
Copy link
Member Author

jackysp commented Feb 6, 2024

/run-monitor-test

Copy link
Contributor

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2024
Copy link

ti-chi-bot bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2024
Copy link

ti-chi-bot bot commented Feb 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-06 08:11:23.809888119 +0000 UTC m=+258009.376658008: ☑️ agreed by you06.
  • 2024-02-06 08:25:31.41895099 +0000 UTC m=+258856.985720881: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 5c95f3b into pingcap:master Feb 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/metrics lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some instance labels are missing in tidb_summary.json
3 participants