-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana: add missing instance filter in tidb_summary.json #51002
Conversation
Signed-off-by: Jack Yu <[email protected]>
Skipping CI for Draft Pull Request. |
Skipping CI for Draft Pull Request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51002 +/- ##
================================================
+ Coverage 70.5780% 72.6286% +2.0506%
================================================
Files 1467 1467
Lines 434825 434842 +17
================================================
+ Hits 306891 315820 +8929
+ Misses 108687 99069 -9618
- Partials 19247 19953 +706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/run-monitor-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
What problem does this PR solve?
Issue Number: close #51001
Problem Summary:
What changed and how does it work?
Add the missing instance label to make Grafana more accurate.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.