Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: add resource group name in stmt context (#49422) #51117

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49422

What problem does this PR solve?

Issue Number: ref #49318

Problem Summary:

What changed and how does it work?

In the current implementation, in order to support statement level hint /* +RESOURCE_GROUP(name) */ to execute a statement under specific resource group, we change the ResourceGroupName in session ctx during optimization and change back after the statement. This is currently done in the function session.ExecuteStmt(with a defer block). This life time may not be long enough as we have other operations such as query slow-log, query duration metrics, statement summary that depend on statement resource group but is run after session.ExecuteStmt is finished.

So this PR add a new field ResourceGroupName in StmtCtx and the /* Resource_Group() */ hint will change this filed isstead of directly change session context and this value can last until the next statement. The PR changes all statement related operation to use this field.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 18, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2024
@glorv glorv force-pushed the cherry-pick-49422-to-release-7.5 branch from 3f5cab1 to 047c6b7 Compare February 19, 2024 03:16
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 19, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 19, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2024
Copy link

ti-chi-bot bot commented Feb 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-19 03:46:38.118718272 +0000 UTC m=+242486.866341383: ☑️ agreed by nolouch.
  • 2024-02-19 03:58:46.467964324 +0000 UTC m=+243215.215587435: ☑️ agreed by glorv.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@bdcd16d). Click here to learn what that means.
The diff coverage is 94.5945%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #51117   +/-   ##
================================================
  Coverage               ?   72.0090%           
================================================
  Files                  ?       1403           
  Lines                  ?     407285           
  Branches               ?          0           
================================================
  Hits                   ?     293282           
  Misses                 ?      94297           
  Partials               ?      19706           
Flag Coverage Δ
unit 72.0090% <94.5945%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3622% <0.0000%> (?)

@glorv
Copy link
Contributor

glorv commented Feb 19, 2024

/retest

@easonn7
Copy link

easonn7 commented Feb 19, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, glorv, nolouch, wjhuang2016, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit eeef0ee into pingcap:release-7.5 Feb 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants