-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log_backup: added more info for slow regions in log backup advancer (#51137) #51174
Merged
ti-chi-bot
merged 3 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-51137-to-release-7.5
Feb 20, 2024
Merged
log_backup: added more info for slow regions in log backup advancer (#51137) #51174
ti-chi-bot
merged 3 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-51137-to-release-7.5
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
5 tasks
YuJuncen
approved these changes
Feb 20, 2024
Leavrth
approved these changes
Feb 20, 2024
Signed-off-by: Yu Juncen <[email protected]>
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #51174 +/- ##
================================================
Coverage ? 71.9975%
================================================
Files ? 1404
Lines ? 407697
Branches ? 0
================================================
Hits ? 293532
Misses ? 94426
Partials ? 19739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/hold |
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #51137
What problem does this PR solve?
Issue Number: close #51046
Problem Summary:
It is painful for debugging slow regions in log backup for now. Exactly when there are many TiKV nodes in the cluster: we only have a range but know nothing about which region this key belongs to.
Also we must pick the TiDB log (which isn't always easily accessible.) for such information.
What changed and how does it work?
This PR added two new series to the log backup advancer, which presents the current slowest region's leader location and its region id.
Also we will append more detailed hints about the slowest range.
Check List
Tests
A simple log:
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.