Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: data type default values support STR_TO_DATE('1980-01-01','%Y-%m-%d') #51278

Merged
merged 6 commits into from
Feb 27, 2024
Merged

ddl: data type default values support STR_TO_DATE('1980-01-01','%Y-%m-%d') #51278

merged 6 commits into from
Feb 27, 2024

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #51276

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2024
@tiprow tiprow
Copy link

tiprow bot commented Feb 23, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pingcap pingcap deleted a comment from ti-chi-bot bot Feb 23, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited
Loading

Codecov Report

Merging #51278 (a8b5905) into master (f4e758a) will increase coverage by 2.1322%.
Report is 2 commits behind head on master.
The diff coverage is 62.5000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #51278        +/-   ##
================================================
+ Coverage   70.6793%   72.8116%   +2.1322%     
================================================
  Files          1460       1460                
  Lines        434615     435193       +578     
================================================
+ Hits         307183     316871      +9688     
+ Misses       108242      98410      -9832     
- Partials      19190      19912       +722
Flag Coverage Δ
integration 48.9854% <12.5000%> (?)
unit 70.4292% <62.5000%> (-0.0453%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4077% <ø> (+5.5239%) ⬆️

Defined2014
Defined2014 reviewed Feb 23, 2024
View reviewed changes
pkg/ddl/ddl_api.go
@@ -1365,6 +1365,17 @@ func getFuncCallDefaultValue(col *table.Column, option *ast.ColumnOption, expr *
}
}
return nil, false, dbterror.ErrDefValGeneratedNamedFunctionIsNotAllowed.GenWithStackByArgs(col.Name.String(), expr.FnName.String())
case ast.StrToDate:
// Support STR_TO_DATE('1980-01-01', '%Y-%m-%d').
if err := expression.VerifyArgsWrapper(expr.FnName.L, len(expr.Args)); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about args not a const? Should we support it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 26, 2024
@zimulala
Copy link
Contributor Author

UT failed because encountered this issue: #51289.

@zimulala
Copy link
Contributor Author

/retest-required

@tiprow tiprow
Copy link

tiprow bot commented Feb 26, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 03:01:35.718142869 +0000 UTC m=+844584.465765979: ☑️ agreed by Defined2014.
  • 2024-02-26 07:45:49.728181463 +0000 UTC m=+861638.475804575: ☑️ agreed by CbcWestwolf.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 26, 2024
@pingcap pingcap deleted a comment from ti-chi-bot bot Feb 27, 2024
@pingcap pingcap deleted a comment from ti-chi-bot bot Feb 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3c3ba00 into pingcap:master Feb 27, 2024
21 checks passed
@zimulala zimulala deleted the zimuxia/str-to-date branch February 27, 2024 05:51
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Mar 1, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 1, 2024
@zimulala @ti-chi-bot
This is an automated cherry-pick of pingcap#51278
f73c609 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51453.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 1, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data type default values support STR_TO_DATE('1980-01-01','%Y-%m-%d')
5 participants
@zimulala @ti-chi-bot @Defined2014 @CbcWestwolf @tangenta