-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: save TS into metadata for external engine, and prepare to use it as startTS #51283
*: save TS into metadata for external engine, and prepare to use it as startTS #51283
Conversation
Signed-off-by: lance6716 <[email protected]>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51283 +/- ##
=================================================
- Coverage 70.5513% 54.9646% -15.5867%
=================================================
Files 1459 1571 +112
Lines 434196 604028 +169832
=================================================
+ Hits 306331 332002 +25671
- Misses 108552 248852 +140300
- Partials 19313 23174 +3861
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -316,6 +316,8 @@ replace ( | |||
// fix potential security issue(CVE-2020-26160) introduced by indirect dependency. | |||
github.com/dgrijalva/jwt-go => github.com/form3tech-oss/jwt-go v3.2.6-0.20210809144907-32ab6a8243d7+incompatible | |||
github.com/go-ldap/ldap/v3 => github.com/YangKeao/ldap/v3 v3.4.5-0.20230421065457-369a3bab1117 | |||
// remove it after https://github.com/pingcap/kvproto/pull/1224 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge kvproto PR after this PR is approved
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
/ok-to-test |
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
This reverts commit 18cb581.
This reverts commit 12725fa.
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
/test pull-lightning-integration-test |
@D3Hunter: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
@lance6716: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
change target branch because kvproto PR will not be merged soon |
0c373ca
into
pingcap:ingest-protocol-start-ts
What problem does this PR solve?
Issue Number: close #46986 ref #51312
Problem Summary:
What changed and how does it work?
for external engine, save the startTS in disttask metadata, so after failover it will not change
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.