Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: save TS into metadata for external engine, and prepare to use it as startTS #51283

Merged
merged 17 commits into from
Feb 26, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Feb 23, 2024

What problem does this PR solve?

Issue Number: close #46986 ref #51312

Problem Summary:

What changed and how does it work?

for external engine, save the startTS in disttask metadata, so after failover it will not change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2024
Copy link

tiprow bot commented Feb 23, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Merging #51283 (5302b8e) into master (a6768bc) will decrease coverage by 15.5867%.
Report is 3 commits behind head on master.
The diff coverage is 65.5737%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51283         +/-   ##
=================================================
- Coverage   70.5513%   54.9646%   -15.5867%     
=================================================
  Files          1459       1571        +112     
  Lines        434196     604028     +169832     
=================================================
+ Hits         306331     332002      +25671     
- Misses       108552     248852     +140300     
- Partials      19313      23174       +3861     
Flag Coverage Δ
integration 37.7872% <65.5737%> (?)
unit 70.3132% <13.1147%> (-0.0067%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 56.5798% <54.1666%> (+10.7652%) ⬆️

@@ -316,6 +316,8 @@ replace (
// fix potential security issue(CVE-2020-26160) introduced by indirect dependency.
github.com/dgrijalva/jwt-go => github.com/form3tech-oss/jwt-go v3.2.6-0.20210809144907-32ab6a8243d7+incompatible
github.com/go-ldap/ldap/v3 => github.com/YangKeao/ldap/v3 v3.4.5-0.20230421065457-369a3bab1117
// remove it after https://github.com/pingcap/kvproto/pull/1224 is merged
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge kvproto PR after this PR is approved

Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 changed the title [WIP]*: save a TS when engine is closed and use it as startTS when ingest [WIP]*: TS of engine should be used as startTS when ingest Feb 26, 2024
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2024
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 26, 2024
Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 changed the title [WIP]*: TS of engine should be used as startTS when ingest *: TS of engine should be used as startTS when ingest Feb 26, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
This reverts commit 18cb581.
This reverts commit 12725fa.
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 26, 2024
Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 changed the title *: TS of engine should be used as startTS when ingest *: save TS into metadata for external engine, and prepare to use it as startTS Feb 26, 2024
Signed-off-by: lance6716 <[email protected]>
@D3Hunter
Copy link
Contributor

/test pull-lightning-integration-test

Copy link

tiprow bot commented Feb 26, 2024

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tidb_parser_test
  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

@lance6716: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 5302b8e link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 06:29:32.030499664 +0000 UTC m=+857060.778122774: ☑️ agreed by D3Hunter.
  • 2024-02-26 07:13:48.002676014 +0000 UTC m=+859716.750299141: ☑️ agreed by tangenta.

@lance6716 lance6716 changed the base branch from master to ingest-protocol-start-ts February 26, 2024 07:39
@lance6716
Copy link
Contributor Author

change target branch because kvproto PR will not be merged soon

@lance6716 lance6716 merged commit 0c373ca into pingcap:ingest-protocol-start-ts Feb 26, 2024
26 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For lightning external engine (global sort), engine TS should keep same after subtask failover
3 participants