Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: force the new upgrading tidb to be owner #51285

Merged
merged 20 commits into from
Sep 25, 2024

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Feb 23, 2024

What problem does this PR solve?

Issue Number: close #57185

Problem Summary:
force the new upgrading tidb to be owner, so that owner can always use the new code during upgrade,

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2024
Signed-off-by: wjhuang2016 <[email protected]>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 58.66667% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.9117%. Comparing base (165c4a5) to head (f32b950).
Report is 22 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51285        +/-   ##
================================================
- Coverage   73.4181%   71.9117%   -1.5064%     
================================================
  Files          1605       1752       +147     
  Lines        445003     549892    +104889     
================================================
+ Hits         326713     395437     +68724     
- Misses        98242     132309     +34067     
- Partials      20048      22146      +2098     
Flag Coverage Δ
integration 50.4370% <5.3333%> (?)
unit 73.4575% <58.6666%> (+0.9495%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 26.0836% <ø> (-19.9474%) ⬇️

Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
Copy link
Member Author

/retest

Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
Copy link

ti-chi-bot bot commented Aug 12, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -1369,6 +1372,77 @@ var (
SupportUpgradeHTTPOpVer int64 = version174
)

func acquireLock(s sessiontypes.Session) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The returning bool value is not used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check it

Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
Copy link
Member Author

/retest

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2024
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
Copy link

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 11:16:17.272247453 +0000 UTC m=+1651047.012671393: ☑️ agreed by Benjamin2037.
  • 2024-09-25 15:15:12.158447162 +0000 UTC m=+1665381.898871098: ☑️ agreed by tangenta.

Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 25, 2024
@wjhuang2016 wjhuang2016 removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024
Copy link

ti-chi-bot bot commented Sep 25, 2024

@wjhuang2016: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 5471b05 link true /test pull-br-integration-test
pull-lightning-integration-test 5471b05 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wjhuang2016
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit a06f6aa into pingcap:master Sep 25, 2024
23 checks passed
Rustin170506 added a commit to Rustin170506/tidb that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force the new upgrading tidb to be the owner
4 participants