Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): dumpling/export/sql_type.go #51589

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

tangjingyu97
Copy link
Contributor

@tangjingyu97 tangjingyu97 commented Mar 7, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 7, 2024
Copy link

ti-chi-bot bot commented Mar 7, 2024

Hi @tangjingyu97. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Mar 7, 2024

Hi @tangjingyu97. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

build/nogo_config.json Outdated Show resolved Hide resolved
@hawkingrei hawkingrei changed the title fix(lint): pkg/parser/parser.go fix(lint): dumpling/export/sql_type.go Mar 7, 2024
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #51589 (92d49e2) into master (d389099) will increase coverage by 2.0716%.
Report is 13 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51589        +/-   ##
================================================
+ Coverage   70.7194%   72.7910%   +2.0716%     
================================================
  Files          1467       1467                
  Lines        436426     436845       +419     
================================================
+ Hits         308638     317984      +9346     
+ Misses       108422      98828      -9594     
- Partials      19366      20033       +667     
Flag Coverage Δ
integration 48.8081% <ø> (?)
unit 70.4680% <100.0000%> (-0.0560%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <100.0000%> (ø)
parser ∅ <ø> (∅)
br 51.4153% <ø> (+5.5562%) ⬆️

@ti-chi-bot ti-chi-bot bot added the component/dumpling This is related to Dumpling of TiDB. label Mar 7, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2024
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Mar 7, 2024
@hawkingrei
Copy link
Member

/retest

@hawkingrei hawkingrei requested a review from lance6716 March 8, 2024 00:02
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 8, 2024
Copy link

ti-chi-bot bot commented Mar 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-07 10:50:02.223845598 +0000 UTC m=+337029.246091988: ☑️ agreed by hawkingrei.
  • 2024-03-08 00:17:28.41936611 +0000 UTC m=+385475.441612497: ☑️ agreed by lance6716.

@lance6716
Copy link
Contributor

/cc @okJiang

@ti-chi-bot ti-chi-bot bot requested a review from okJiang March 8, 2024 08:00
Copy link

ti-chi-bot bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit f01d941 into pingcap:master Mar 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants