Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Support TopN Spill #51809

Merged
merged 289 commits into from
May 15, 2024
Merged

executor: Support TopN Spill #51809

merged 289 commits into from
May 15, 2024

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #47733

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

windtalker
windtalker reviewed Apr 29, 2024
View reviewed changes
pkg/executor/sortexec/topn.go Show resolved Hide resolved
pkg/executor/sortexec/topn.go Outdated Show resolved Hide resolved
windtalker
windtalker approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 30, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-19 05:28:48.313705992 +0000 UTC m=+575147.424752441: ☑️ agreed by SeaRise.
  • 2024-04-30 05:59:13.027222415 +0000 UTC m=+336906.784357988: ☑️ agreed by windtalker.

@xzhangxian1008
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented May 11, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented May 13, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented May 13, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@xzhangxian1008
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented May 14, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 4eca4eb into pingcap:master May 15, 2024
21 checks passed
@xzhangxian1008 xzhangxian1008 deleted the topn-spill branch May 15, 2024 12:24
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@xzhangxian1008 @terry1purcell
executor: Support TopN Spill (pingcap#51809)
fc03b92 
ref pingcap#47733
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
@xzhangxian1008 @RidRisR
executor: Support TopN Spill (pingcap#51809)
0f2e629 
ref pingcap#47733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xzhangxian1008 @SeaRise @windtalker