-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
placement: fix alter placement policy cannot update the relative ranges policy #52254
Conversation
Hi @jiyfhust. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52254 +/- ##
================================================
+ Coverage 70.1622% 73.9705% +3.8082%
================================================
Files 1485 1511 +26
Lines 419217 467558 +48341
================================================
+ Hits 294132 345855 +51723
+ Misses 105672 101191 -4481
- Partials 19413 20512 +1099
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
/test tidb_parser_test |
@jiyfhust: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jiyfhust Please sync with master. |
/cc @nolouch |
/retest-required |
/cc @zimulala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks!
/cc @xhebox |
PTAL @zimulala @Benjamin2037 |
/cc @Benjamin2037 |
/test |
@nolouch: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, xhebox, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
…es policy (pingcap#52254) close pingcap#51712, close pingcap#52257
…es policy (pingcap#52254) close pingcap#51712, close pingcap#52257
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #51712 close #52257
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.