-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: rebase auto random id if the table is common handle #52256
Conversation
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may add a simple test case at br_views_and_sequences
or br_incompatible_tidb_config
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52256 +/- ##
================================================
- Coverage 72.3907% 70.7875% -1.6033%
================================================
Files 1486 1547 +61
Lines 365580 455432 +89852
================================================
+ Hits 264646 322389 +57743
- Misses 81378 112527 +31149
- Partials 19556 20516 +960
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yes, I thinks it's the best way to merge these kind of cases into one script. Because it saves time for cluster restart. However, it makes things more complicated in the current scripts framework. Therefore, I would open a new script. |
Signed-off-by: Leavrth <[email protected]>
/test pull-br-integration-test |
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Leavrth <[email protected]>
/cc @tangenta plta. |
@YuJuncen: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-br-integration-test |
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/unhold |
Signed-off-by: Leavrth <[email protected]>
/test pull-br-integration-test |
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52255
Problem Summary:
the
auto_rand_base
of table with common handle isn't be rebased by BR.What changed and how does it work?
rebase the
auto_rand_base
of table with common handleCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.