Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: rebase auto random id if the table is common handle #52256

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Mar 30, 2024

What problem does this PR solve?

Issue Number: close #52255

Problem Summary:
the auto_rand_base of table with common handle isn't be rebased by BR.

What changed and how does it work?

rebase the auto_rand_base of table with common handle

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Mar 30, 2024
Copy link

tiprow bot commented Mar 30, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may add a simple test case at br_views_and_sequences or br_incompatible_tidb_config

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Merging #52256 (8cbb2fa) into master (7b8fd37) will decrease coverage by 1.6032%.
Report is 47 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52256        +/-   ##
================================================
- Coverage   72.3907%   70.7875%   -1.6033%     
================================================
  Files          1486       1547        +61     
  Lines        365580     455432     +89852     
================================================
+ Hits         264646     322389     +57743     
- Misses        81378     112527     +31149     
- Partials      19556      20516       +960     
Flag Coverage Δ
integration 28.6223% <0.0000%> (?)
unit 70.9580% <0.0000%> (-1.3237%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 33.6614% <0.0000%> (-12.6807%) ⬇️

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 31, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Apr 1, 2024

You may add a simple test case at br_views_and_sequences or br_incompatible_tidb_config

Yes, I thinks it's the best way to merge these kind of cases into one script. Because it saves time for cluster restart. However, it makes things more complicated in the current scripts framework. Therefore, I would open a new script.

Signed-off-by: Leavrth <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Apr 1, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Apr 1, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

/cc @tangenta plta.

Copy link

ti-chi-bot bot commented Apr 1, 2024

@YuJuncen: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-30 14:57:32.854225664 +0000 UTC m=+110314.381766207: ☑️ agreed by YuJuncen.
  • 2024-04-01 09:44:43.49837833 +0000 UTC m=+264345.025918876: ☑️ agreed by tangenta.

@Leavrth
Copy link
Contributor Author

Leavrth commented Apr 1, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Apr 1, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Apr 1, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Apr 1, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
Signed-off-by: Leavrth <[email protected]>
@Leavrth
Copy link
Contributor Author

Leavrth commented Apr 1, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Apr 1, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Apr 1, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Apr 1, 2024
@ti-chi-bot ti-chi-bot bot merged commit f7a8004 into pingcap:master Apr 1, 2024
28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52292.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 1, 2024
@Leavrth Leavrth added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Apr 1, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52295.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52296.

@Leavrth Leavrth added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Apr 2, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 2, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #52317.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br doesn't rebase auto random if table's PKIsHandle is false
5 participants