-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
point-get: calculate the row level checksum on the real time to avoid incorrect checksum caused by schema change #52511
point-get: calculate the row level checksum on the real time to avoid incorrect checksum caused by schema change #52511
Conversation
Hi @3AceShowHand. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52511 +/- ##
=================================================
+ Coverage 57.7692% 74.6444% +16.8752%
=================================================
Files 1409 1511 +102
Lines 396668 449799 +53131
=================================================
+ Hits 229152 335750 +106598
+ Misses 150078 93812 -56266
- Partials 17438 20237 +2799
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1b858cc
to
e3ad463
Compare
707258f
to
741a694
Compare
/retest |
@3AceShowHand: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
if !rowcodec.IsNewFormat(val) { | ||
checksumCols.AppendNull(0) | ||
continue | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be explained in user documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got your point, I think we can update the documentation to let user's know tat checksum only calculated on the new format.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, XuHuaiyu, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… incorrect checksum caused by schema change (pingcap#52511) close pingcap#52590
… incorrect checksum caused by schema change (pingcap#52511) close pingcap#52590
What problem does this PR solve?
Issue Number: close #52590
Problem Summary:
What changed and how does it work?
tidb_row_checksum
calculate the column-level checksum in the real time, instead of return the checksum store in the TiKV when the row insertedCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.