Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: return 0 early on empty parquet files (#52519) #52522

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52519

What problem does this PR solve?

Issue Number: close #52518

Problem Summary:

What changed and how does it work?

If the Parquet file is empty, directly set the size to be 0.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Importing empty tables via Parquet no longer crash.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 12, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Apr 12, 2024
br/pkg/lightning/mydump/loader_test.go Outdated Show resolved Hide resolved
br/pkg/lightning/mydump/loader_test.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-7.5@2ecc47d). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52522   +/-   ##
================================================
  Coverage               ?   71.9869%           
================================================
  Files                  ?       1410           
  Lines                  ?     409434           
  Branches               ?          0           
================================================
  Hits                   ?     294739           
  Misses                 ?      94859           
  Partials               ?      19836           
Flag Coverage Δ
unit 71.9869% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3495% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 12, 2024
Copy link

ti-chi-bot bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 1, 2024
Copy link

ti-chi-bot bot commented May 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 08:53:13.43419658 +0000 UTC m=+1211654.961737122: ☑️ agreed by lance6716.
  • 2024-05-01 02:13:10.61473685 +0000 UTC m=+409744.371872424: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 61c4bd6 into pingcap:release-7.5 May 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants